New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New: Add no-useless-backreference rule (fixes #12673) #12690
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One small documentation request and one comment in a typo, otherwise this looks fantastic. Love the test coverage. Great work!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Really appreciate all the thorough documentation in both the actual docs and the tests.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me, thanks!
Thanks for contributing! |
What is the purpose of this pull request? (put an "X" next to item)
[ X] New rule #12673
Examples of incorrect code for this rule:
What changes did you make? (Give an overview)
New rule:
no-useless-backreference
Is there anything you'd like reviewers to focus on?
Is the logic correct - are backreferences in these 5 cases which the rule targets always ignored?